Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cylc play: add suggestion for --upgrade in non-interactive terminal #5535

Merged
merged 3 commits into from
May 18, 2023
Merged

cylc play: add suggestion for --upgrade in non-interactive terminal #5535

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
51dcc05
add message on how to use --upgrade
wxtim May 12, 2023
d8c13f8
Update cylc/flow/scheduler_cli.py
wxtim May 15, 2023
55edc5b
Update cylc/flow/scheduler_cli.py
wxtim May 15, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions cylc/flow/scheduler_cli.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -523,6 +523,7 @@ def _version_check(
process=str.lower,
)
# we are in non-interactive mode, abort abort abort
print('Use "--upgrade" to upgrade the workflow.', file=sys.stderr)
Copy link
Member

@MetRonnie MetRonnie May 15, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is a bit of a mismatch printing this to stderr when just above

This workflow was previously run with <yellow>{last_run_version}</yellow>.
This version of Cylc is <green>{__version__}</green>.

was printed to stdout.

Would there be anything wrong with printing that earlier message to stderr also? Would solve this problem #5381 (comment)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@oliver-sanders - Any reason not to print the earlier msg to stderr?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is a bit of a mismatch printing this to stderr when just above

Eh, not really, those messages are informational, this message conveys an actual error.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unfortunately the GUI and TUI are only regurgitating stderr. We should find a way for them to include the useful info about which versions are flying about IMHO

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fair point, but a widespread issue not related to this PR.

I don't think stdout/err are a great interface for Tui/GUI, but short of a Python API (that allows Cylc version changing) I can't think of a better option that isn't tons of work.

In this case, the version compat issue should also be handled better in at the UI end as we intend to implement upgrade logic there.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Moved to #5554

return False
elif itt > 2 and this > that:
# restart would INCREASE the Cylc version in a little way
Expand Down