Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

setup: pin matplotlib for python 3.7 #5734

Closed
wants to merge 1 commit into from

Conversation

oliver-sanders
Copy link
Member

@oliver-sanders oliver-sanders commented Sep 19, 2023

  • Matplotlib has dropped Python 3.7 support in version 3.8.0.
  • This causes mypy to fail.
  • Exclude the new, incompatible matplotlib version for Python 3.7 installations.

Check List

  • I have read CONTRIBUTING.md and added my name as a Code Contributor.
  • Contains logically grouped changes (else tidy your branch by rebase).
  • Does not contain off-topic changes (use other PRs for other changes).
  • Applied any dependency changes to both setup.cfg (and conda-environment.yml if present).
  • Tests are included (or explain why tests are not needed).
  • CHANGES.md entry included if this is a change that can affect users
  • Cylc-Doc pull request opened if required at cylc/cylc-doc/pull/XXXX.
  • If this is a bug fix, PR should be raised against the relevant ?.?.x branch.

* Matplotlib has dropped Python 3.7 support in version 3.8.0.
* This causes `mypy` to fail.
* Exclude the new, incompatible matplotlib version for Python 3.7
  installations.
@oliver-sanders oliver-sanders self-assigned this Sep 19, 2023
@oliver-sanders
Copy link
Member Author

Nope.

@oliver-sanders oliver-sanders deleted the mypy-matplotlib branch September 19, 2023 13:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant