Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix job runner stdout missing newline #6081

Open
wants to merge 6 commits into
base: 8.3.x
Choose a base branch
from
Open

Fix job runner stdout missing newline #6081

wants to merge 6 commits into from

Commits on Oct 23, 2024

  1. fix bug when job runner submit stdout doesn't end with newline 

    When the stdout returned by the job runner submit method doesn't end with
a newline, the `sys.stdout.write` call in `jobs_submit` do not add it and
this cases submission to fails (at least to be recorded as failed by the
calling process when running a workflow).

Looking at how newlines are handled in the JobRunnerManager.job_kill method,
it looks like this a typo in the jobs_submit method.
    @jennan @hjoliver
    jennan authored and hjoliver committed Oct 23, 2024
    Configuration menu
    Copy the full SHA
    c140412 View commit details
    Browse the repository at this point in the history

  2. add name to contributors

    @jennan @hjoliver
    jennan authored and hjoliver committed Oct 23, 2024
    Configuration menu
    Copy the full SHA
    a00fcfa View commit details
    Browse the repository at this point in the history

  3. Tweak as per code review.

    @hjoliver
    hjoliver committed Oct 23, 2024
    Configuration menu
    Copy the full SHA
    adbcdfc View commit details
    Browse the repository at this point in the history

  4. Simplify some job_runner code.

    @hjoliver
    hjoliver committed Oct 23, 2024
    Configuration menu
    Copy the full SHA
    2a43d24 View commit details
    Browse the repository at this point in the history

  5. Update change log.

    @hjoliver
    hjoliver committed Oct 23, 2024
    Configuration menu
    Copy the full SHA
    32aed6a View commit details
    Browse the repository at this point in the history

  6. Update mailmap.

    @hjoliver
    hjoliver committed Oct 23, 2024
    Configuration menu
    Copy the full SHA
    f1fb504 View commit details
    Browse the repository at this point in the history