Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade towncrier #6269

Merged
merged 1 commit into from
Jul 31, 2024
Merged

Upgrade towncrier #6269

merged 1 commit into from
Jul 31, 2024

Conversation

MetRonnie
Copy link
Member

@MetRonnie MetRonnie commented Jul 30, 2024

Supersedes #6216

towncrier build will now fail as part of CI if you create a file in changes.d/ with an invalid fragment file name, thanks to my PR twisted/towncrier#622 (needs the ignore setting added to the towncrier config).

Check List

  • I have read CONTRIBUTING.md and added my name as a Code Contributor.
  • Contains logically grouped changes (else tidy your branch by rebase).
  • Does not contain off-topic changes (use other PRs for other changes).
  • Dev dependency change does not apply to conda
  • Tests are not needed
  • No changelog entry needed
  • No docs needed
  • If this is a bug fix, PR should be raised against the relevant ?.?.x branch.

@MetRonnie MetRonnie added infrastructure GH Actions, Codecov etc. dependencies labels Jul 30, 2024
@MetRonnie MetRonnie added this to the 8.3.4 milestone Jul 30, 2024
@MetRonnie MetRonnie requested a review from wxtim July 30, 2024 13:46
@MetRonnie MetRonnie self-assigned this Jul 30, 2024
@MetRonnie
Copy link
Member Author

(No need to run the functional tests so I've cancelled them)

@MetRonnie
Copy link
Member Author

Test failures are unrelated, fixed by #6257

@MetRonnie MetRonnie merged commit fd25604 into 8.3.x Jul 31, 2024
26 of 38 checks passed
@MetRonnie MetRonnie deleted the towncrier branch July 31, 2024 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants