Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement group trigger proposal: cylc/cylc-admin#197
(Not approved yet, but it's a clear winner and a relatively small change, and I wanted to finish coding it up - after initial experiments - while still fresh in the brain).
On current master:
On this branch:
Result: we can trigger a sub-graph "naturally" by specifying all of its member tasks:
This provides an alternative, easier for some cases, to triggering just the initial task(s) of the sub-graph and setting off-flow prerequisites (if any) manually.
example
Run it and wait for
bar
to fail and stall the workflow.caveats?
Triggering a future sub-graph, or a past sub-graph with
--flow=new
, is safe and easy.But triggering a past sub-graph in the original flow comes with a gotcha: setting off-group prerequisites spawns the target task to wait on other prerequisites, which aren't going to get satisfied when the original flow does not re-traverse the graph.
This isn't technically incorrect. The exact same thing would happen if we attempted to trigger the same past sub-graph the spawn-on-demand "native" way in the same flow: trigger the initial task and set the off-flow prerequisite.
But maybe we can do something to mitigate the problem if users try to do this.
interaction with the upcoming
cylc remove
extensionOn this branch now, to re-run a past sub-graph you have to use
--flow=new
.After the
remove
extension we'll be able to erase the flow history and re-run a past sub-graph in the original flow. We may want to add an option tocylc trigger
to do that automatically, or even make it the default.interaction with upcoming inactive task matching developments
We can't trigger a group of inactive tasks by family name or glob yet, but that's a general problem, not specific to this branch.
Check List
CONTRIBUTING.md
and added my name as a Code Contributor.setup.cfg
(andconda-environment.yml
if present).?.?.x
branch.