data store: dont update outputs incrementally #6403
Draft
+19
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8 tasks
This comment was marked as resolved.
This comment was marked as resolved.
oliver-sanders
force-pushed
the
dont-update-outputs-incrementally
branch
from
591632f
to
a23100c
Compare
This comment was marked as resolved.
This comment was marked as resolved.
| output.satisfied = _output.satisfied | ||
|
|
||
| output.time = update_time | ||
|
|
||
| self.updates_pending = True | ||
|
|
||
| def delta_task_outputs(self, itask: TaskProxy) -> None: |
There was a problem hiding this comment.
Might as well only use this (below) call instead.. Unless you want to keep the other as a placeholder.
There was a problem hiding this comment.
Maybe just call delta_task_outputs from within delta_task_output with a comment for future improvement.
There was a problem hiding this comment.
This is a bodge workaround, I'm not sure whether we should merge it.
The incremental update is the right thing to do (so I don't want to blast that code aside), we just didn't develop a mechanism for syncing these updates over GraphQL so the UI can't handle it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An awkward bodge to work around #6307
I'm not sure we want to go ahead with this, at least not in the long term, however, it should be enough to unblock (at lest the review of) cylc/cylc-ui#1886
Check List
CONTRIBUTING.mdand added my name as a Code Contributor.setup.cfg(andconda-environment.ymlif present).?.?.xbranch.