Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pass pre-install plugins the value of workflow rundir #6404

Open
wants to merge 1 commit into
base: 8.3.x
Choose a base branch
from
Open

Pass pre-install plugins the value of workflow rundir #6404

wants to merge 1 commit into from

Conversation

wxtim
Copy link
Member

@wxtim wxtim commented Oct 11, 2024 •
edited
Loading

Closes #6286

Set options.against_source to the rundir of the workflow, allowing re-install and validate against source to access previous CLI opts as stored in rose-suite-cylc-install.conf

Paired with cylc/cylc-rose#345

Check List

  • I have read CONTRIBUTING.md and added my name as a Code Contributor.
  • Contains logically grouped changes (else tidy your branch by rebase).
  • Does not contain off-topic changes (use other PRs for other changes).
  • Applied any dependency changes to both setup.cfg (and conda-environment.yml if present).
  • Tests are included (or explain why tests are not needed).
  • Changelog entry included if this is a change that can affect users
  • Cylc-Doc pull request opened if required at cylc/cylc-doc/pull/XXXX.
  • If this is a bug fix, PR should be raised against the relevant ?.?.x branch.

@wxtim wxtim mentioned this pull request Oct 11, 2024
Open
8 tasks
@wxtim wxtim marked this pull request as draft October 11, 2024 14:58
@wxtim
Pass pre-install plugins the value of workflow rundir
11333b0 
as options.against source, allowing re-install and validate
against source to access previous CLI opts as stored
in rose-suite-cylc-install.conf
@wxtim wxtim self-assigned this Oct 14, 2024
@wxtim wxtim added the bug Something is wrong :( label Oct 14, 2024
@wxtim wxtim marked this pull request as ready for review October 14, 2024 12:16
@wxtim wxtim linked an issue Oct 14, 2024 that may be closed by this pull request
cylc vr: installed options are not applied before validate #6286
Open
@wxtim wxtim added this to the 8.3.5 milestone Oct 14, 2024
@oliver-sanders oliver-sanders modified the milestones: 8.3.5, 8.3.6 Oct 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oliver-sanders oliver-sanders Awaiting requested review from oliver-sanders

@markgrahamdawson markgrahamdawson Awaiting requested review from markgrahamdawson

At least 1 approving review is required to merge this pull request.

Assignees

@wxtim wxtim

Labels
bug Something is wrong :(
Projects
None yet
Milestone
8.3.6
Development

Successfully merging this pull request may close these issues.

cylc vr: installed options are not applied before validate
2 participants
@wxtim @oliver-sanders