Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cat-log: list out/err files when available via tailer #6480

Draft
wants to merge 1 commit into
base: 8.4.x
Choose a base branch
from

Conversation

oliver-sanders
Copy link
Member

@oliver-sanders oliver-sanders commented Nov 15, 2024

Closes #5802

List log files that are not present on disk but which are available via a tailer.

Check List

  • I have read CONTRIBUTING.md and added my name as a Code Contributor.
  • Contains logically grouped changes (else tidy your branch by rebase).
  • Does not contain off-topic changes (use other PRs for other changes).
  • Applied any dependency changes to both setup.cfg (and conda-environment.yml if present).
  • Tests are included (or explain why tests are not needed).
  • Changelog entry included if this is a change that can affect users
  • Cylc-Doc pull request opened if required at cylc/cylc-doc/pull/XXXX.
  • If this is a bug fix, PR should be raised against the relevant ?.?.x branch.

@oliver-sanders oliver-sanders changed the base branch from master to 8.3.x November 15, 2024 14:36
@oliver-sanders oliver-sanders added this to the 8.3.7 milestone Nov 15, 2024
@oliver-sanders oliver-sanders self-assigned this Nov 15, 2024
@oliver-sanders oliver-sanders added the could be better Not exactly a bug, but not ideal. label Nov 15, 2024
@oliver-sanders
Copy link
Member Author

Note: This approach works just fine, however, it has a couple of small caveats:

  • It isn't checking whether the out/err files have appeared in the output already reported - i.e. we could get duplicate job.out / job.err files in the output.
  • The job.out and job.err files will always appear at the end, not in alphabetical order.

Ideally, we would avoid these caveats. I did start looking at a solution where I added the job.out and job.err files onto the end of the mode variable, e.g. mode = list-dirs:job.out:job.err, that way they can be output along with the regular directory listing in a much more elegant way.

But I ran out of time. Writing this up in case anyone else needs to take this one over.

@hjoliver hjoliver modified the milestones: 8.3.7, 8.4.1 Jan 8, 2025
@MetRonnie MetRonnie changed the base branch from 8.3.x to 8.4.x January 9, 2025 18:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
could be better Not exactly a bug, but not ideal.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants