Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

stem: use Cylc host selection interface #361

Open
wants to merge 1 commit into
base: 1.5.x
Choose a base branch
from

Conversation

oliver-sanders
Copy link
Member

  • The ROSE_ORIG_HOST variable is set using the Cylc interface.
  • The HOST_SOURCE... rose-stem variables are set using the Rose interface.
  • The two interfaces differ, Cylc picks long hostnames, Rose picks short ones.
  • The inconsistency may cause issues with simplistic "is this localhost" checks.
  • The shortnames are causing issues at one site.
  • Switch to using the Cylc interface for all scenarios.

Check List

  • I have read CONTRIBUTING.md and added my name as a Code Contributor.
  • Contains logically grouped changes (else tidy your branch by rebase).
  • Does not contain off-topic changes (use other PRs for other changes).
  • Applied any dependency changes to both setup.cfg (and conda-environment.yml if present).
  • Tests are included (or explain why tests are not needed).
  • Changelog entry included if this is a change that can affect users
  • Cylc-Doc pull request opened if required at cylc/cylc-doc/pull/XXXX.
  • If this is a bug fix, PR should be raised against the relevant ?.?.x branch.

@oliver-sanders oliver-sanders added this to the 1.5.x milestone Jan 23, 2025
@oliver-sanders oliver-sanders requested a review from wxtim January 23, 2025 14:02
@oliver-sanders oliver-sanders self-assigned this Jan 23, 2025
* The `ROSE_ORIG_HOST` variable is set using the Cylc interface.
* The `HOST_SOURCE...` rose-stem variables are set using the Rose
  interface.
* The two interfaces differ, Cylc picks long hostnames, Rose picks short
  ones.
* The inconsistency may cause issues with simplistic "is this localhost"
  checks.
* The shortnames are causing issues at one site.
* Switch to using the Cylc interface for all scenarios.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants