Skip to content

Commit

Permalink
Apply suggestions from code review
Browse files Browse the repository at this point in the history
Co-authored-by: Ronnie Dutta <[email protected]>
  • Loading branch information
oliver-sanders and MetRonnie authored Dec 11, 2024
1 parent 9b33929 commit 7a451e6
Show file tree
Hide file tree
Showing 3 changed files with 20 additions and 17 deletions.
24 changes: 12 additions & 12 deletions cypress/component/info.cy.js
Original file line number Diff line number Diff line change
Expand Up @@ -161,23 +161,23 @@ describe('Info component', () => {
.find('.prerequisite-alias.condition')
.should('have.length', 6)
.then((selector) => {
expect(selector[0]).to.contain('(0 & 1) | 2')
expect(selector[0].classList.toString()).to.equal('prerequisite-alias condition')
expect(selector[0].innerText).to.equal('(0 & 1) | 2')
expect(selector[0]).to.not.have.class('satisfied')

expect(selector[0]).to.contain('0')
expect(selector[1].classList.toString()).to.equal('prerequisite-alias condition satisfied')
expect(selector[1].innerText).to.equal('0 a:succeeded')
expect(selector[1]).to.have.class('satisfied')

expect(selector[0]).to.contain('1')
expect(selector[2].classList.toString()).to.equal('prerequisite-alias condition')
expect(selector[2].innerText).to.equal('1 b:custom_output')
expect(selector[2]).to.not.have.class('satisfied')

expect(selector[0]).to.contain('2')
expect(selector[3].classList.toString()).to.equal('prerequisite-alias condition')
expect(selector[3].innerText).to.equal('2 a:expired')
expect(selector[3]).to.not.have.class('satisfied')

expect(selector[0]).to.contain('0')
expect(selector[4].classList.toString()).to.equal('prerequisite-alias condition satisfied')
expect(selector[4].innerText).to.equal('0')
expect(selector[4]).to.have.class('satisfied')

expect(selector[0]).to.contain('0')
expect(selector[5].classList.toString()).to.equal('prerequisite-alias condition satisfied')
expect(selector[5].innerText).to.equal('0 x:succeeded')
expect(selector[5]).to.have.class('satisfied')
})

// the outputs panel
Expand Down
6 changes: 5 additions & 1 deletion src/services/mock/json/infoView.json
Original file line number Diff line number Diff line change
Expand Up @@ -73,7 +73,11 @@
"label": "expired",
"satisfied": false
}
]
],

"runtime": {
"completion": "succeeded"
}
}
]
}
Expand Down
7 changes: 3 additions & 4 deletions tests/e2e/specs/info.cy.js
Original file line number Diff line number Diff line change
Expand Up @@ -19,13 +19,12 @@ describe('Info View', () => {
it('works', () => {
// test opening the "Info View" from a task in the "Tree View"
cy.visit('/#/workspace/one')
// click on task 20000102T0000Z/failed
.get('.c-treeitem .c-treeitem .c-treeitem:first')
.find('.c-task')
// click on task
.get('.node-data-task [data-c-interactive]:first')
.click({ force: true })

// from the menu select the "Info" psudo-mutation
.get('.v-list > :nth-child(6)')
.get('.v-list-item')
.contains('Info')
.click({ force: true })

Expand Down

0 comments on commit 7a451e6

Please sign in to comment.