-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
graph: family collapsing #1130
Comments
Attempt along with #1280 |
For the time being - figure out a means of drawing a dotted box around families. This can be done with graphviz subgraphs The graphviz dot code is returned from the Dot code can be rendered with ultimately in the svg there will need to be a |
Some ideas for a unified approach to grouping/collapsing cycles/families. I'm suggesting unifying the handling of cycles and families (note, cycles represent the "root" family so they are essentially the same thing). Grouping/Ungrouping - Drawing dashed boxes around a cycle/family. Collapsing/Expanding - Reducing a family down to a single node. Limitations of the Cylc 7 approach:
Note, for simplicity, this approach groups/collapses all instances of selected families rather than managing this at a per-cycle level. I think this is probably more aligned with expectations, but does represent a minor limitation, e.g. there's no ability to collapse all but one cycle. The ability to expand/collapse specific cycle instances would be a reasonable enhancement. Design Sketch Had a quick discussion on this (more to come):
|
Implement family expand/collapse in the graph view.
In the Cylc 7 graph view families were represented with a special node shape & expansion was available via a right-click menu. When a family was expanded the special node was removed and the tasks it represented were added in its place.
With the Cylc 8 graph view we have more power over rendering so can do something more advanced. One thing I'd like to consider is expanding families into subgraphs so that the family name is preserved which should make graphs easier to understand.
Pull requests welcome!
The text was updated successfully, but these errors were encountered: