Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Centralise task filtering into own component; list task states in logical order #1123

Merged
merged 4 commits into from
Jan 4, 2023

Conversation

MetRonnie
Copy link
Member

Requirements check-list

  • I have read CONTRIBUTING.md and added my name as a Code Contributor.
  • Contains logically grouped changes (else tidy your branch by rebase).
  • Does not contain off-topic changes (use other PRs for other changes).
  • Appropriate tests are included (unit and/or functional).
  • No change log entry required (mostly invisible to users).
  • No documentation update required.

@MetRonnie MetRonnie added this to the 1.4.0 milestone Oct 25, 2022
@MetRonnie MetRonnie self-assigned this Oct 25, 2022
@oliver-sanders
Copy link
Member

Due to the refactoring this will be a tricky one to reconcile with the graph view / data store work as filtering works in a different way when views are powered from the central data store.

@hjoliver
Copy link
Member

Due to the refactoring this will be a tricky one to reconcile with the graph view / data store work ...

What's your suggestion - shelve this one?

@MetRonnie
Copy link
Member Author

I have looked at #1108 and I don't see too much surface area for conflict, only a handful of lines

@oliver-sanders
Copy link
Member

I haven't got filtering working in all views on that branch yet. The main difference is that in order to drive the views off of the central data store we cannot change the data or set attributes on it directly. Instead we must store the filter state in the view locally.

I'm going to try to get back to that branch this week to see if I can clear out the remaining issues and find out.

@MetRonnie
Copy link
Member Author

Note that currently this new filter component does not house the logic of the filtering, that is left up to the parent components that use/embed the filter component

@MetRonnie MetRonnie marked this pull request as draft November 11, 2022 13:04
@MetRonnie
Copy link
Member Author

Converting to draft, will be easier to deconflict this one after #1108 has gone in

@oliver-sanders oliver-sanders modified the milestones: 1.4.0, 1.5.0 Dec 7, 2022
@MetRonnie MetRonnie force-pushed the filter-order branch 3 times, most recently from d359fee to 457c8f5 Compare December 19, 2022 13:06
@MetRonnie MetRonnie marked this pull request as ready for review December 19, 2022 13:09
Copy link
Member

@oliver-sanders oliver-sanders left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@@ -0,0 +1,38 @@
/**
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps move into src/utils?

@oliver-sanders oliver-sanders modified the milestones: 1.5.0, 1.4.0 Dec 20, 2022
@MetRonnie MetRonnie requested a review from wxtim December 23, 2022 11:34
Copy link
Member

@wxtim wxtim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Read code.
  • Tried functionality.

@wxtim wxtim merged commit 09c3827 into cylc:master Jan 4, 2023
@wxtim wxtim mentioned this pull request Jan 4, 2023
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

view toolbar: task state filter should list task states in logical order
4 participants