Edit runtime (deconflicted) #1160
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Allow a mutation argument type to be associated with a cylc object type (cycle, task etc.) without auto filling that object into the form input - Add icon for Edit Runtime
Uses introspection to expand fields of the query if none specified
Update introspection query response in mock service
Avoids need to manually reset state of form
Because that's the order they appear in the broadcast
Simplify help icon logic - it now shows help on hover instead of click
Adapt AOTF's handling of 'INPUT_OBJECT' for 'OBJECT' seeing as the former is not used?
- Remain open with loading spinner in the submit button while awaiting the mutation response - Show error snackbar and stay open on failed submission - Show warning snackbar and stay open if the Edit-Runtime form does not have any changes on submission
* Each node in the store is now associated with its UID type (user, workflow, cycle, task, job, $edge, $namespace). * Use this type for mutation listing rather than trying to infer whether a task is a family or not by looking at its node contents. * Simplify some internals.
* Test passes reliably without the wait.
Functional Tests
Possible enhancements for future
|
4 tasks
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Superseedes #1144
This is Ronnie's
edit-runtime-deconflictbranch which he prepared in anticipation of the graph-view/central-data-store PR being merged.I've pushed an extra commit which removes some of the workarounds that were needed before the central data store was implemented. Address these review comments:
Please review the last commit and perform some functional testing.
Requirements check-list
CONTRIBUTING.mdand added my name as a Code Contributor.