Analysis view: use initialOptions to save & restore view state on navigation
#1744
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
markgrahamdawson
changed the title
markgrahamdawson
changed the title
initialOptions to save & restore view state on navigation
8 tasks
MetRonnie
reviewed
Apr 9, 2024
MetRonnie
added
data workflows team
MetRonnie
reviewed
Apr 10, 2024
markgrahamdawson
force-pushed
the
lumino-adv-analysis
branch
from
f65e813
to
0fd7c99
Compare
MetRonnie
approved these changes
Apr 11, 2024
|
@JAllen42 or @ChrisPaulBennett could 1 of you review this? |
|
@MetRonnie I'm on it |
MetRonnie
reviewed
Apr 16, 2024
MetRonnie
reviewed
Apr 17, 2024
MetRonnie
reviewed
Apr 19, 2024
Use a template ref to ensure we only teleport once analysis view has been mounted
markgrahamdawson
force-pushed
the
lumino-adv-analysis
branch
from
a9fc686
to
b086ef3
Compare
MetRonnie
reviewed
Apr 30, 2024
MetRonnie
reviewed
Apr 30, 2024
markgrahamdawson
force-pushed
the
lumino-adv-analysis
branch
from
6aeea88
to
528ec15
Compare
|
@MetRonnie, @markgrahamdawson, two approvals, good to merge? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These changes build on the work undertaken to save & restore workspace layout on navigation #1664
Which is part of a larger issue #662
There was an equivalent pull request for the log view #1688
There is an equivalent pull request for the tree view which this builds on: #1705
There is an equivalent pull request for the table view which this builds on: #1711
There is an equivalent pull request for the graph view which this builds on: #1717
Check List
CONTRIBUTING.mdand added my name as a Code Contributor.setup.cfg(andconda-environment.ymlif present).CHANGES.mdentry included if this is a change that can affect users?.?.xbranch.