-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
schema: add source workflows #512
base: master
Are you sure you want to change the base?
Conversation
Looks fine, tests passing. |
Is that a formal review/approval @dwsutherland ? |
Getting this into subscriptions would make sense, making it easier for cylc-ui views to access this information. Would we have to add these fields in cylc-flow or could we shim them into cylc-uiserver similar to how we extend the GraphQL schema? |
Well, if we add this to the
|
Because this is UIS specific functionality that the Scheduler should never know about it would be better to try and keep this logic centralised in cylc-uiserver. Is is possible to extend the protobuf schema in a similar way to how we extend the GraphQL schema? |
Ah, so it's not about knowing the source of installed/running workflows, it's about knowing Yeah, better to keep it at UIS then, and we shouldn't need to deal with protobuf .. can just extend the subscriptions at the UIS |
Ok, I'll look into doing that. Would it be possible to extend the store to hold this or would I need to add a parallel store? |
(may as well draft this until the fields are available in subscriptions) |
Add source workflows to the schema.
Unblocks cylc/cylc-ui#548, though we will probably want to extend this to subscriptions for that.
Check List
CONTRIBUTING.md
and added my name as a Code Contributor.setup.cfg
(andconda-environment.yml
if present).CHANGES.md
entry included if this is a change that can affect users?.?.x
branch.