graphql-ws: optimise the "resolve" routine #548
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Partially addresses cylc#547 * The resolve routine is implmented recursively in the graphql-ws library. * Because the function is async this results in a large number of async tasks being created when the library is used with large, deeply nested schema. * Async tasks have an overhead, above that of regular function calls. * For the example in cylc#547 this resulted in over 10 seconds of overheads.
oliver-sanders
force-pushed
the
graphql-ws-resolve-optimisation
branch
from
39e9f83 to
6c6a2b4
Compare
This was referenced Jan 10, 2024
wxtim
reviewed
Jan 10, 2024
wxtim
reviewed
Jan 10, 2024
|
IMO Adding it and modifying it : Would be nice if these were separate commits to keep that info in the repo history? |
oliver-sanders
force-pushed
the
graphql-ws-resolve-optimisation
branch
from
65b274f to
a5d49e2
Compare
* Due to inheritance, we were calling `resolve(execution_result.data)` twice.
oliver-sanders
force-pushed
the
graphql-ws-resolve-optimisation
branch
from
a5d49e2 to
1311fbb
Compare
|
That's somewhat satisfying @oliver-sanders !
|
wxtim
reviewed
Jan 11, 2024
wxtim
reviewed
Jan 11, 2024
There was a problem hiding this comment.
- Read code. I have views on readability, but I'm happy that the change replicates the functioning of the original. Might be nice to unit test it?
- Tried it out. Looks like there is a considerable speed gain for larger workflows.
Not pressed the approve button because it's still draft, presumably indicating futher work to come?
Might we unit test this function?
oliver-sanders
commented
Jan 30, 2024
wxtim
reviewed
Jan 30, 2024
wxtim
approved these changes
Jan 30, 2024
|
The actual diff is trivial and we're choked up ATM so might just slide this through on 1. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Results 96% saving!:
base_async.resolve):resolve.resolve):Suggest adding this routine to the cylc-uiserver library for now as the graphql-ws library is not currently maintained (see #333).
The original implementation can be found here: https://github.com/graphql-python/graphql-ws/blob/7ef25ecfaf5390bf1a0cb4023272d8cb074368c2/graphql_ws/base_async.py#L37-L62
TODO:
Check List
CONTRIBUTING.mdand added my name as a Code Contributor.setup.cfg(andconda-environment.ymlif present).CHANGES.mdentry included if this is a change that can affect users?.?.xbranch.