Server supports custom headers #1152
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Shadow243
force-pushed
the
server-supports-custom-headers
branch
from
2b053be
to
b1bd138
Compare
|
@Shadow243 I am fine to do a workaround for just one server, but please add a link to stalwartlabs/mail-server#477 in the source code so we remove the workaround if ever Stalwart no longer needs it. |
Shadow243
force-pushed
the
server-supports-custom-headers
branch
from
b1bd138
to
39c7a6a
Compare
Done. |
kroky
reviewed
Aug 9, 2024
Shadow243
force-pushed
the
server-supports-custom-headers
branch
from
39c7a6a
to
73f5997
Compare
Shadow243
force-pushed
the
server-supports-custom-headers
branch
from
73f5997
to
700f49c
Compare
|
Potential regression: #1195 |
Shadow243
commented
Aug 27, 2024
| @@ -1099,7 +1099,7 @@ public function search($target='ALL', $uids=false, $terms=array(), $esearch=arra | |||
| if ($only_auto_bcc) { | |||
There was a problem hiding this comment.
I think the same conditions must have been here too
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Based on a discussion from the Stalwart GitHub issue https://github.com/stalwartlabs/mail-server/discussions/477, it appears that Stalwart's IMAP server only indexes standard headers defined in RFCs and does not support searching custom headers (such as
X-Auto-Bcc) by default. This design choice is intended to optimize server performance by maintaining a manageable index size, as most users typically search by common fields like recipients, subjects, or message contents.Key Points
X-Auto-Bcc) because these headers are not indexed.A
server_supports_custom_headersfunction is implemented to determine if the server supports searching custom headers. This function sends a test command to the server and inspects the response to check for support.Related Issue: https://github.com/cypht-org/cypht/issues/1149