refactor(other): promote JMAP & EWS in the UI

[Bienvenumoringa]

Related task

Modify the text in the help section to explain that Cypht supports the JMAP (RFC8621) protocol in addition to IMAP and SMTP, and make JMAP available by default in standalone Cypht installations or those integrated with Tiki.

[Shadow243]

You don't need to repeat it after SMTP. it's already okay after IMAP as it's an imap alternative, like this:

you can use a cndition like this:

$res .= sprintf(
                        $this->trans('You have %d %s%s'),
                        $server_data[$proto],
                        mb_strtoupper($proto_dsp),
                        ($proto === 'imap' ? ' / JMAP ' . $server_data['jmap'] . ($server_data[$proto] > 1 ? ' sources' : ' source') : ($server_data[$proto] > 1 ? ' sources' : ' source'))
                    );

and filter from here:

if (data_source_available($modules, 'imap')) {
            $imap_servers = count(array_filter(Hm_IMAP_List::dump(false), function($v) { return !array_key_exists('type', $v);}));
            $jmap_servers = count(array_filter(Hm_IMAP_List::dump(false), function($v) { return array_key_exists('type', $v) && $v['type'] == 'jmap'; }));
        }

$this->out('nux_server_setup', array(
            'imap' => $imap_servers,
            'jmap' => $jmap_servers,
            'feeds' => $feed_servers,
            'smtp' => $smtp_servers,
            'profiles' => $profiles
        ));

[Bienvenumoringa]

You don't need to repeat it after SMTP. it's already okay after IMAP as it's an` imap` alternative, like this:

you can use a cndition like this:

$res .= sprintf(
                        $this->trans('You have %d %s%s'),
                        $server_data[$proto],
                        mb_strtoupper($proto_dsp),
                        ($proto === 'imap' ? ' / JMAP ' . $server_data['jmap'] . ($server_data[$proto] > 1 ? ' sources' : ' source') : ($server_data[$proto] > 1 ? ' sources' : ' source'))
                    );

and filter from here:

if (data_source_available($modules, 'imap')) {
            $imap_servers = count(array_filter(Hm_IMAP_List::dump(false), function($v) { return !array_key_exists('type', $v);}));
            $jmap_servers = count(array_filter(Hm_IMAP_List::dump(false), function($v) { return array_key_exists('type', $v) && $v['type'] == 'jmap'; }));
        }

$this->out('nux_server_setup', array(
            'imap' => $imap_servers,
            'jmap' => $jmap_servers,
            'feeds' => $feed_servers,
            'smtp' => $smtp_servers,
            'profiles' => $profiles
        ));

apply changers

[Shadow243]

One more change and we are done. Make sure you rebase too to make selenium test working

[Shadow243]

Check your logs, there is an Fatal error PHP Fatal error: Uncaught TypeError: count(): Argument #1 ($value) must be of type Countable|array, int given in

[Bienvenumoringa]

Check your logs, there is an Fatal error PHP Fatal error: Uncaught TypeError: count(): Argument #1 ($value) must be of type Countable|array, int given in

It okay @Shadow243

[Shadow243]

It okay @Shadow243

There is a calculation error, try locally especially with several servers connected and correct, then ping me

[Shadow243]

We will no longer need to add at sesction Welcome to Cypht because it will come with #1278 but we can update section Help may be add EWS too

[kroky]

Oops, yes, #1278 already included separation of imap, jmap, ews and smtp servers, so no need to do it here.

[Shadow243]

@marclaporte I added EWS too

[marclaporte]

Here is the sentence now:
Cypht is a webmail program. You can use it to access your E-mail accounts from any service that offers IMAP, or SMTP access - which most do. And Cypht also supports the newest protocol: JMAP (RFC8621) and EWS.').

It is a little convoluted and some may not know what EWS.

I propose:

Cypht is a webmail aggregator client. You can use it to access your E-mail accounts from any server or service that offers any of the main protocols: IMAP/SMTP, Exchange Web Services (EWS) or the newest protocol: JMAP (RFC8621).