refactor: begin to use axios for cloud api requests #31041
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cypress
|
||||||||||||||||||||||||||||||||||||||||
| Project |
cypress
|
| Branch Review |
refactor/axios/create-instance
|
| Run status |
|
| Run duration | 18m 39s |
| Commit |
|
| Committer | Cacie Prins |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
10
|
Pending
|
1232
|
Skipped
|
0
|
Passing
|
32101
|
| View all changes introduced in this branch ↗︎ | |
Warning
Partial Report: The results for the Application Quality reports may be incomplete.
UI Coverage
46.31%
|
|
|---|---|
|
Untested elements
|
184
|
|
Tested elements
|
163
|
Accessibility
92.52%
|
|
|---|---|
|
Failed rules
|
3 critical
7 serious
2 moderate
1 minor
|
|
Failed elements
|
875
|
cacieprins
commented
Feb 27, 2025
| @@ -4,14 +4,19 @@ import Debug from 'debug' | |||
|
|
|||
| const debug = Debug('cypress-verbose:server:is-retryable-error') | |||
|
|
|||
| export const isRetryableError = (error?: Error) => { | |||
| export const isRetryableError = (error: unknown) => { | |||
There was a problem hiding this comment.
Potential errors should be considered unknown - subsequent logic performed on them should gate based on runtime type detection. Setting useUnknownInCatchVariables is considered best practice - and can be checked by typescript-eslint even in cases of promise .catch, so it's honored here.
cacieprins
commented
Feb 27, 2025
| }) | ||
| }) | ||
|
|
||
| it('tags errors', function () { |
There was a problem hiding this comment.
This test is redundant due to the transformError axios middleware and its unit tests, so it's removed in the move to create_instance_spec.ts
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Additional details
As a first step in removing @cypress/request, this shifts the API call to create an instance to Axios.
api/index.tsfileasyncRetryutil.axios-retrywas considered, but the additional package size and complications regarding overriding behavior for POSTs made it untimely.@packages/server, but should be considered a TODO if we migrate to vitest.Note: while this request is a POST, and POSTs are not typically retry-able, this endpoint is now idempotent. Retries are enabled in order to improve resiliency to network splits, etc.
Steps to test
How has the user experience changed?
PR Tasks
cypress-documentation?type definitions?