-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
misc: (studio) add support for url routing #31205
Open
mschile
wants to merge
10
commits into
develop
Choose a base branch
from
mschile/studio/url_updates
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
+965
−124
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cypress
|
Project |
cypress
|
Branch Review |
mschile/studio/url_updates
|
Run status |
|
Run duration | 18m 58s |
Commit |
|
Committer | Jennifer Shehane |
View all properties for this run ↗︎ |
Test results | |
---|---|
|
0
|
|
9
|
|
1232
|
|
0
|
|
32125
|
View all changes introduced in this branch ↗︎ |
UI Coverage
46.44%
|
|
---|---|
|
183
|
|
163
|
Accessibility
92.55%
|
|
---|---|
|
3 critical
8 serious
2 moderate
2 minor
|
|
877
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Additional details
testId
andstudio
https://example.cypress.io/__/#/specs/runner?file=cypress/e2e/1-getting-started/todo.cy.js&studio=&testId=r3
suiteId
,testId
, andstudio
https://example.cypress.io/__/#/specs/runner?file=cypress/e2e/1-getting-started/todo.cy.js&studio=&testId=r3&suiteId=r2
Updates to the
EventManager
class:packages/app/src/runner/event-manager.ts
: Added a success handler for thestudio:save
event to callsaveSuccess
on thestudioStore
.packages/app/src/runner/event-manager.ts
: Removed thestudio
property from the resolved run state to simplify the state management.Modifications to the
StudioControls.vue
component:packages/app/src/runner/studio/StudioControls.vue
: Addeddata-cy
attributes to various elements for better testability and identification in Cypress tests. [1] [2] [3] [4] [5]Improvements to the
studio-store
module:packages/app/src/store/studio-store.ts
: Implemented URL parameter handling methods (_updateUrlParams
,_removeUrlParams
,_getUrlParams
) to maintain the studio state across page reloads and navigation.Steps to test
Launch Studio and test different scenarios.
How has the user experience changed?
Modify existing test:

Add new test:

PR Tasks
cypress-documentation
?type definitions
?