Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

misc: (studio) add support for url routing #31205

Open
wants to merge 10 commits into
base: develop
Choose a base branch
from

Conversation

mschile
Copy link
Contributor

@mschile mschile commented Mar 1, 2025

Additional details

  • Added the following url parameters when the user enters studio mode:
    • When modifying a test: testId and studio
      • e.g. https://example.cypress.io/__/#/specs/runner?file=cypress/e2e/1-getting-started/todo.cy.js&studio=&testId=r3
    • When adding a new test: suiteId, testId, and studio
      • e.g. https://example.cypress.io/__/#/specs/runner?file=cypress/e2e/1-getting-started/todo.cy.js&studio=&testId=r3&suiteId=r2
  • The url parameters are removed when the user exits studio mode (either cancelling or saving)
  • If the user is in studio mode and reloads the page, studio mode maintained (the pending commands are lost)
  • Fixed an issue where if the save fails, we partially exited studio mode. Now, we will remain completely in studio mode but the error message is still not displayed (it wasn't shown previously either).

Updates to the EventManager class:

Modifications to the StudioControls.vue component:

Improvements to the studio-store module:

  • packages/app/src/store/studio-store.ts: Implemented URL parameter handling methods (_updateUrlParams, _removeUrlParams, _getUrlParams) to maintain the studio state across page reloads and navigation.

Steps to test

Launch Studio and test different scenarios.

How has the user experience changed?

Modify existing test:
Screenshot 2025-02-28 at 7 29 11 PM

Add new test:
Screenshot 2025-02-28 at 7 32 57 PM

PR Tasks

Copy link

cypress bot commented Mar 1, 2025

cypress    Run #60718

Run Properties:  status check passed Passed #60718  •  git commit 72a5f885b5: Merge branch 'develop' into mschile/studio/url_updates
Project cypress
Branch Review mschile/studio/url_updates
Run status status check passed Passed #60718
Run duration 18m 58s
Commit git commit 72a5f885b5: Merge branch 'develop' into mschile/studio/url_updates
Committer Jennifer Shehane
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 9
Tests that did not run due to a developer annotating a test with .skip  Pending 1232
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 32125
View all changes introduced in this branch ↗︎
UI Coverage  46.44%
  Untested elements 183  
  Tested elements 163  
Accessibility  92.55%
  Failed rules  3 critical   8 serious   2 moderate   2 minor
  Failed elements 877  

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants