-
Notifications
You must be signed in to change notification settings - Fork 3.3k
DRAFT: refactor cypress cli to ts #32063
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: release/15.0.0
Are you sure you want to change the base?
Conversation
cypress
|
Project |
cypress
|
Branch Review |
chore/refactor_cli_to_ts
|
Run status |
|
Run duration | 20m 53s |
Commit |
|
Committer | Bill Glesias |
View all properties for this run ↗︎ |
Test results | |
---|---|
|
0
|
|
14
|
|
1105
|
|
0
|
|
26519
|
View all changes introduced in this branch ↗︎ |
UI Coverage
45.14%
|
|
---|---|
|
187
|
|
158
|
Accessibility
97.82%
|
|
---|---|
|
4 critical
8 serious
2 moderate
2 minor
|
|
109
|
5e4e990
to
b06e770
Compare
rebase into first
rebase into second
…piled down to CommonJS
b06e770
to
34448c3
Compare
…s differently since the refactor and is printing non deterministic outputs into our tests that do not have a large impact on the area we are testing and mostly served to actually test the renders of the listr2 framework itself
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bug: Pipeline Trigger Bug in TypeScript Migration
The trigger-publish-binary-pipeline.js
script was modified to trigger pipelines from the development branch chore/migrate_cli_to_typescript
instead of release/15.0.0
. This temporary change, intended for TypeScript migration testing and present in both the top-level branch
parameter and within the parameters
object, should not be merged to production as it would cause binary publishing from the incorrect branch.
scripts/binary/trigger-publish-binary-pipeline.js#L12-L20
cypress/scripts/binary/trigger-publish-binary-pipeline.js
Lines 12 to 20 in 1ddfa5e
const body = JSON.stringify({ | |
branch: 'chore/migrate_cli_to_typescript', | |
parameters: { | |
temp_dir: os.tmpdir(), | |
sha: process.env.CIRCLE_SHA1, | |
job_name: process.env.CIRCLE_JOB, | |
triggered_workflow_id: process.env.CIRCLE_WORKFLOW_ID, | |
triggered_job_url: process.env.CIRCLE_BUILD_URL, | |
branch: 'chore/migrate_cli_to_typescript', |
Bug: SIGINT Handler Delay Causes Zombie Processes
The SIGINT handler's change from synchronous require('tree-kill')
to asynchronous await import('tree-kill')
introduces a delay in process termination. This can prevent timely cleanup and potentially leave zombie processes running when users interrupt Cypress with Ctrl+C.
cli/lib/exec/spawn.ts#L290-L295
Lines 290 to 295 in 1ddfa5e
// this makes sure all nested processes are closed(ex: firefox inside the server) | |
rl.on('SIGINT', async function () { | |
const kill = (await import('tree-kill')).default | |
kill(child.pid as number, 'SIGINT') | |
}) |
Was this report helpful? Give feedback by reacting with 👍 or 👎
passing CI on 1ddfa5e empty commit |
Additional details
Steps to test
How has the user experience changed?
PR Tasks
cypress-documentation
?type definitions
?