Skip to content

DRAFT: refactor cypress cli to ts #32063

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 15 commits into
base: release/15.0.0
Choose a base branch
from

Conversation

AtofStryker
Copy link
Contributor

  • Closes

Additional details

Steps to test

How has the user experience changed?

PR Tasks

cursor[bot]

This comment was marked as outdated.

cursor[bot]

This comment was marked as outdated.

Copy link

cypress bot commented Jul 21, 2025

cypress    Run #64009

Run Properties:  status check passed Passed #64009  •  git commit 1ddfa5e85a: empty commit
Project cypress
Branch Review chore/refactor_cli_to_ts
Run status status check passed Passed #64009
Run duration 20m 53s
Commit git commit 1ddfa5e85a: empty commit
Committer Bill Glesias
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 14
Tests that did not run due to a developer annotating a test with .skip  Pending 1105
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 26519
View all changes introduced in this branch ↗︎
UI Coverage  45.14%
  Untested elements 187  
  Tested elements 158  
Accessibility  97.82%
  Failed rules  4 critical   8 serious   2 moderate   2 minor
  Failed elements 109  

cursor[bot]

This comment was marked as outdated.

cursor[bot]

This comment was marked as outdated.

@AtofStryker AtofStryker force-pushed the chore/refactor_cli_to_ts branch from 5e4e990 to b06e770 Compare July 21, 2025 22:20
cursor[bot]

This comment was marked as outdated.

@AtofStryker AtofStryker force-pushed the chore/refactor_cli_to_ts branch from b06e770 to 34448c3 Compare July 22, 2025 14:41
cursor[bot]

This comment was marked as outdated.

cursor[bot]

This comment was marked as outdated.

cursor[bot]

This comment was marked as outdated.

…s differently since the refactor and is printing non deterministic outputs into our tests that do not have a large impact on the area we are testing and mostly served to actually test the renders of the listr2 framework itself
cursor[bot]

This comment was marked as outdated.

Copy link

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: Pipeline Trigger Bug in TypeScript Migration

The trigger-publish-binary-pipeline.js script was modified to trigger pipelines from the development branch chore/migrate_cli_to_typescript instead of release/15.0.0. This temporary change, intended for TypeScript migration testing and present in both the top-level branch parameter and within the parameters object, should not be merged to production as it would cause binary publishing from the incorrect branch.

scripts/binary/trigger-publish-binary-pipeline.js#L12-L20

const body = JSON.stringify({
branch: 'chore/migrate_cli_to_typescript',
parameters: {
temp_dir: os.tmpdir(),
sha: process.env.CIRCLE_SHA1,
job_name: process.env.CIRCLE_JOB,
triggered_workflow_id: process.env.CIRCLE_WORKFLOW_ID,
triggered_job_url: process.env.CIRCLE_BUILD_URL,
branch: 'chore/migrate_cli_to_typescript',

Fix in CursorFix in Web


Bug: SIGINT Handler Delay Causes Zombie Processes

The SIGINT handler's change from synchronous require('tree-kill') to asynchronous await import('tree-kill') introduces a delay in process termination. This can prevent timely cleanup and potentially leave zombie processes running when users interrupt Cypress with Ctrl+C.

cli/lib/exec/spawn.ts#L290-L295

// this makes sure all nested processes are closed(ex: firefox inside the server)
rl.on('SIGINT', async function () {
const kill = (await import('tree-kill')).default
kill(child.pid as number, 'SIGINT')
})

Fix in CursorFix in Web


Was this report helpful? Give feedback by reacting with 👍 or 👎

@AtofStryker
Copy link
Contributor Author

passing CI on 1ddfa5e empty commit

@AtofStryker AtofStryker marked this pull request as draft July 22, 2025 21:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant