internal: Update URL styles, disabled state, and viewport tag styling #32109
+253
−384
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: jennifer <[email protected]>
|
|
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
cypress
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
| Project |
cypress
|
| Branch Review |
cursor/update-url-input-active-styles-84a4
|
| Run status |
|
| Run duration | 19m 21s |
| Commit |
|
| Committer | Jennifer Shehane |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
3
|
Flaky
|
9
|
Pending
|
1102
|
Skipped
|
0
|
Passing
|
26506
|
| View all changes introduced in this branch ↗︎ | |
UI Coverage
45.11%
|
|
|---|---|
|
Untested elements
|
186
|
|
Tested elements
|
157
|
Accessibility
97.7%
|
|
|---|---|
|
Failed rules
|
4 critical
8 serious
2 moderate
2 minor
|
|
Failed elements
|
109
|
Tests for review
cypress/e2e/studio/studio.cy.ts • 1 failed test • app-e2e
| Test | Artifacts | |
|---|---|---|
| Cypress Studio > remains in studio mode when the test name is changed on the file system and file watching is disabled |
Test Replay
Screenshots
|
|
cypress/e2e/cypress-in-cypress-component.cy.ts • 1 failed test • app-e2e
| Test | Artifacts | |
|---|---|---|
| Cypress In Cypress CT > default config > test component |
Test Replay
Screenshots
|
|
src/components/Collapsible.cy.tsx • 1 failed test • frontend-shared-ct
| Test | Artifacts | |
|---|---|---|
| An uncaught error was detected outside of a test |
Test Replay
|
|
issues/28527.cy.ts • 1 flaky test • 5x-driver-electron
| Test | Artifacts | |
|---|---|---|
| issue 28527 > fails and then retries and verifies about:blank is not displayed |
Test Replay
Screenshots
|
|
e2e/e2e_cookies.cy.js • 1 flaky test • 5x-driver-chrome
| Test | Artifacts | |
|---|---|---|
| e2e cookies spec > __Host- prefix > can set __Host- cookie |
Test Replay
|
|
issues/28527.cy.ts • 1 flaky test • 5x-driver-chrome
| Test | Artifacts | |
|---|---|---|
| issue 28527 > fails and then retries and verifies about:blank is not displayed |
Test Replay
Screenshots
|
|
commands/net_stubbing.cy.ts • 1 flaky test • 5x-driver-firefox
| Test | Artifacts | |||||||
|---|---|---|---|---|---|---|---|---|
| ... > stops waiting when an xhr request is canceled |
| |||||||
| Test | Artifacts | |
|---|---|---|
| src/cy/commands/files > #readFile > retries to read when ENOENT |
The first 5 flaky specs are shown, see all 9 specs in Cypress Cloud. | |
jennifer-shehane
changed the title
jennifer-shehane
changed the title
| @@ -1,43 +0,0 @@ | |||
| import StudioUrlPrompt from './StudioUrlPrompt.vue' | |||
There was a problem hiding this comment.
Old Studio Prompt URL with the popover/overlay
|
|
||
| it('does not display', () => { |
There was a problem hiding this comment.
Redundant test and it's not describing what it's actually testing?!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Figma
Additional details
This change addresses a few things:
.aut-url-inputwhen it is active or focused.tagcomponents of the AUT viewport size/percentage not matching the Figma designSteps to test
How has the user experience changed?
Default with no URL
Default with URL (disabled)
Hover state
Focus when Studio Needs Url
Focus when URL entered
PR Tasks
cypress-documentation?type definitions?