chore(DRAFT): make the @packages/telemetry an independent bundle
#32623
+178
−55
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cypress
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
| Project |
cypress
|
| Branch Review |
chore/bundle_telemetry
|
| Run status |
|
| Run duration | 20m 01s |
| Commit |
|
| Committer | Bill Glesias |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
1
|
Flaky
|
15
|
Pending
|
1102
|
Skipped
|
4
|
Passing
|
26690
|
| View all changes introduced in this branch ↗︎ | |
Warning
Partial Report: The results for the Application Quality reports may be incomplete.
UI Coverage
45.11%
|
|
|---|---|
|
Untested elements
|
186
|
|
Tested elements
|
157
|
Accessibility
97.96%
|
|
|---|---|
|
Failed rules
|
4 critical
8 serious
2 moderate
2 minor
|
|
Failed elements
|
101
|
Tests for review
cypress/e2e/studio/studio.cy.ts • 1 failed test • app-e2e
| Test | Artifacts | |
|---|---|---|
| Cypress Studio > creates a new test from an empty spec |
Test Replay
Screenshots
|
|
issues/28527.cy.ts • 1 flaky test • 5x-driver-electron
| Test | Artifacts | |
|---|---|---|
| issue 28527 > fails and then retries and verifies about:blank is not displayed |
Test Replay
Screenshots
|
|
e2e/origin/config_env.cy.ts • 1 flaky test • 5x-driver-inject-document-domain-chrome
| Test | Artifacts | |
|---|---|---|
| cy.origin- Cypress.config() > serializable > overwrites different values in secondary if one exists in the primary |
Test Replay
|
|
commands/waiting.cy.js • 1 flaky test • 5x-driver-chrome:beta
| Test | Artifacts | |
|---|---|---|
| ... > errors > throws when waiting for 2nd response to route |
Test Replay
|
|
e2e/origin/config_env.cy.ts • 1 flaky test • 5x-driver-chrome:beta
| Test | Artifacts | |
|---|---|---|
| cy.origin- Cypress.config() > serializable > overwrites different values in secondary if one exists in the primary |
Test Replay
|
|
issues/28527.cy.ts • 1 flaky test • 5x-driver-chrome:beta
| Test | Artifacts | |
|---|---|---|
| issue 28527 > fails and then retries and verifies about:blank is not displayed |
Test Replay
Screenshots
|
|
The first 5 flaky specs are shown, see all 15 specs in Cypress Cloud.
AtofStryker
changed the title
@packages/telemetry an independent bundle
…ded ts-node to register entrypoint. Both ESM and CJS distributions are built and types are used as source to be compatible with older styles of commonjs bundling. Types are not shipped with the package.
AtofStryker
force-pushed
the
chore/bundle_telemetry
branch
from
611d915 to
5262613
Compare
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
| "target": "ES2022", | ||
| "module": "ES2022", | ||
| "moduleResolution": "node", | ||
| "noEmit": true |
There was a problem hiding this comment.
Bug: ESM Build Fails Due to noEmit Setting
The tsconfig.esm.json has "noEmit": true, which prevents the ESM build from generating its expected output files in the esm/ directory. This means the intended ESM package build won't produce its artifacts.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Additional details
Makes
@packages/telemetryan independent bundle. This change, similar to #32633, builds@packages/telemetrywith 3 entry points:browserdirectory.We are somewhat limited with an older
moduleResolutionand can't leverage exports similar to the CLI, the best we can do is userollupto move/rename the compiled browser bundle (NOTE:node_modulesdependencies are external and will be resolved by the package) to have abrowserentry point, and omit theclientfile in thenodebuild.We bundle delcarations with the code so we don't have to worry about type checking the telemetry package in other extraneous monorepo packages as we are no longer importing from source
TODO: needs to be tested with the telemetry client
Steps to test
How has the user experience changed?
PR Tasks
cypress-documentation?type definitions?Note
Restructures @packages/telemetry into separate CJS/ESM/browser builds and switches all browser imports to
@packages/telemetry/browser/client, with docs/tests and minor proxy handling updates.cjs/(Node CJS),esm/(Node ESM), and bundledbrowser/client(Rollup).package.json(main/types/module, build scripts), add Rollup config and tsconfigs; remove TS runtimeindex.jsloader.src/telemetry/index.ts), adjustTelemetryNooptypings.@packages/telemetry/src/browser→@packages/telemetry/browser/clientinpackages/app,driver, and runner telemetry events.packages/telemetryas completed in ESM migration guide.isVerbose).network-proxy.ts(span || undefined).Written by Cursor Bugbot for commit 5262613. This will update automatically on new commits. Configure here.