chore: use cloud validations for packages/server api request/response types #32632
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cypress
|
||||||||||||||||||||||||||||||||||||||||
| Project |
cypress
|
| Branch Review |
chore/use-api-typedefs
|
| Run status |
|
| Run duration | 20m 20s |
| Commit |
|
| Committer | Cacie Prins |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
10
|
Pending
|
1102
|
Skipped
|
0
|
Passing
|
26666
|
| View all changes introduced in this branch ↗︎ | |
UI Coverage
44.86%
|
|
|---|---|
|
Untested elements
|
188
|
|
Tested elements
|
157
|
Accessibility
97.71%
|
|
|---|---|
|
Failed rules
|
4 critical
8 serious
2 moderate
2 minor
|
|
Failed elements
|
110
|
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
| return | ||
| return cb(response) | ||
| } catch (err: unknown) { | ||
| debug('postInstanceTests failed, allowing browser to hang until it is killed: Error %o', { err }) |
There was a problem hiding this comment.
Bug: Error Handling Skipped After Refactor
The refactor removed the onError(err) callback invocation when _postInstanceTests fails. Errors are now only logged, skipping the onError call that previously handled error reporting or cleanup logic.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Additional details
System tests currently fetch typescript definitions and example payloads for API endpoints when they run. This ensures our api calls are supported properly by the server.
This adds the same functionality to packages/server, so we can make sure our api functions use up-to-date typedefs from Cypress Cloud
Steps to test
How has the user experience changed?
PR Tasks
cypress-documentation?type definitions?Note
Switches server API request/response types to Cloud validations and adds scripts to fetch them, with minor logic, typing, and error-handling updates.
../../validations/cloudValidationstypes forcreateRun,createInstance,postInstanceResults,postInstanceTests, andupdateInstanceStdout.PutInstanceArtifactsResponseTypeplaceholder type.scripts/sync-cloud-validations.shand wire topostinstall,build-prod, andcheck-tsviasync-cloud-validations/ensure-cloud-validations.zod; ignore generatedlib/validationsin repo (.gitignore).lib/cloud/api/index.tsandcreate_instance.ts(incl.setPreflightResult,resetPreflightResult,ping, etc.).createInstancerequest/response; keep retry/backoff behavior.testingTypeise2eorcomponent._postInstanceTeststoasyncwithtry/catch; adjustonTestsReceivedto handle failures by hanging the browser and handle SPEC SKIP actions.Written by Cursor Bugbot for commit 681153e. This will update automatically on new commits. Configure here.