-
Notifications
You must be signed in to change notification settings - Fork 3.4k
feat: exit with code 112 when api errors prevent cloud orchestrated runs (record mode, parallel run mode) #32635
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
22 commits
Select commit
Hold shift + click to select a range
5ac2316
feat: exit with code 112 on fatal api errors when posix error codes a…
cacieprins 17c1002
rm dead code
cacieprins 79be6fe
ts
cacieprins d401df8
system tests for 112 exit code
cacieprins d61e91d
Merge branch 'develop' into feat-api-failure-exit-112
cacieprins 9affeaa
Merge branch 'develop' into feat-api-failure-exit-112
cacieprins 3e891c9
fix race condition w/ exit codes
cacieprins 2d5528b
only 112 on network errors, not http errors
cacieprins 25724e9
have connection timeouts run a little bit faster in system tests
cacieprins c321884
Merge branch 'develop' into feat-api-failure-exit-112
cacieprins 12a8a1e
new schema for network errors
cacieprins e903179
112 should only be on network errors, update integration test
cacieprins b405587
changelog
cacieprins afed8c5
Merge branch 'develop' into feat-api-failure-exit-112
cacieprins eb8b28b
changelog
cacieprins ba640a1
coerce boolean
cacieprins edcf651
Merge branch 'develop' into feat-api-failure-exit-112
cacieprins 3f096f2
code review
cacieprins 660ab1b
review
cacieprins 7c11f77
rm extra debug
cacieprins 4152a21
Merge branch 'develop' into feat-api-failure-exit-112
cacieprins 65d7718
Merge branch 'develop' into feat-api-failure-exit-112
cacieprins File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8 changes: 8 additions & 0 deletions
8
packages/errors/test/__snapshots__/CLOUD_CANNOT_PROCEED_IN_PARALLEL_NETWORK.ansi
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,8 @@ | ||
[31mWe encountered an unexpected error communicating with our servers.[39m | ||
[31m[39m | ||
[31m[95mError: fail whale[39m[31m[39m | ||
[31m[39m | ||
[31mBecause you passed the [95m--parallel[39m[31m flag, this run cannot proceed since it requires a valid response from our servers.[39m | ||
[31m[39m | ||
[31mThe --group flag you passed was: [33mfoo[39m[31m[39m | ||
[31mThe --ciBuildId flag you passed was: [33minvalid[39m[31m[39m |
8 changes: 8 additions & 0 deletions
8
packages/errors/test/__snapshots__/CLOUD_CANNOT_PROCEED_IN_SERIAL_NETWORK.ansi
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,8 @@ | ||
[31mWe encountered an unexpected error communicating with our servers.[39m | ||
[31m[39m | ||
[31m[95mError: fail whale[39m[31m[39m | ||
[31m[39m | ||
[31mBecause you passed the [95m--record[39m[31m flag, this run cannot proceed since it requires a valid response from our servers.[39m | ||
[31m[39m | ||
[31mThe --group flag you passed was: [33mfoo[39m[31m[39m | ||
[31mThe --ciBuildId flag you passed was: [33minvalid[39m[31m[39m |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is so much easier to diff now
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It really really is!