-
Notifications
You must be signed in to change notification settings - Fork 3.4k
chore: convert @packages/icons
to a compiled package and convert tests to vitest
#32649
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
AtofStryker
wants to merge
5
commits into
develop
Choose a base branch
from
chore/icons_vitest
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vitest
84f6420
to
27aa98a
Compare
cypress
|
Project |
cypress
|
Branch Review |
chore/icons_vitest
|
Run status |
|
Run duration | 10m 53s |
Commit |
|
Committer | Bill Glesias |
View all properties for this run ↗︎ |
Test results | |
---|---|
|
0
|
|
0
|
|
3
|
|
0
|
|
857
|
View all changes introduced in this branch ↗︎ |
UI Coverage
45.7%
|
|
---|---|
|
137
|
|
117
|
Accessibility
97.36%
|
|
---|---|
|
3 critical
7 serious
2 moderate
1 minor
|
|
77
|
vitest
@packages/icons
to a compiled package and convert tests to vitest
03d443e
to
3cf811e
Compare
jennifer-shehane
approved these changes
Oct 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Additional details
Converts
@packages/icons
to use vitest and removes the ts-node entrypoint making ESM possible. The tests before weren't actually being run in CI. This adds the icons package to the test script so the tests are now executedSteps to test
How has the user experience changed?
PR Tasks
cypress-documentation
?type definitions
?Note
Compiles
@packages/icons
with CJS/ESM entrypoints, migrates tests to Vitest, and adds the package to the root test run while updating related configs/docs.index.js
(CJS) andindex.mjs
(ESM); introducetsconfig.cjs.json
/tsconfig.esm.json
and sharedtsconfig.base.json
; updatepackage.json
scripts (build
,build-assets
,build:cjs
,build:esm
) and fields (module
,types
); usetsx
for build scripts; adjust dist path inindex.ts
.vitest.config.ts
, newtest/icons.spec.ts
), remove oldtest/icons_spec.ts
; switchtest-unit
tovitest run
; add ignore rules for built artifacts.@packages/icons
in top-leveltest
script.guides/esm-migration.md
to markpackages/icons
as completed and tidyhttps-proxy
entries.Written by Cursor Bugbot for commit 549af08. This will update automatically on new commits. Configure here.