internal: rename excludeFromAI type #32653
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* feat: cy prompt infrastructure * refactor and add tests * refactor * rename experimental config * prompt * fix test * Update cy-prompt-development.md * Update cy-prompt-development.md * PR comments * Update packages/server/lib/cloud/api/cy-prompt/get_cy_prompt_bundle.ts Co-authored-by: Copilot <[email protected]> * PR comments --------- Co-authored-by: Copilot <[email protected]>
* chore: add cdp connection to cy prompt * minor fix * fix type build * try to fix build * Update packages/server/lib/browsers/browser-cri-client.ts Co-authored-by: Bill Glesias <[email protected]> * Update packages/server/lib/browsers/browser-cri-client.ts Co-authored-by: Bill Glesias <[email protected]> * do not support prompt in firefox or webkit * rework timing of lifecycle * refactor * fix tests * troubleshooting * troubleshooting * fix tests * additional troubleshooting * additional troubleshooting * additional troubleshooting * attempt to fix build * add back * debugging * debugging * debugging * debugging * clean up * fix unit tests * rework --------- Co-authored-by: Bill Glesias <[email protected]>
…#31803) * chore: add promptBackend as an additional Cypress-attached function * Update packages/app/src/runner/event-manager.ts * update types * fix types * fix spacing * refactor * additional refactor * fix type build * fix build * refactor * reword messages * fix * debugging * undo debugging * PR comment * fix tests * fix tests * fix tests * fix test
* chore: add watcher for cy-prompt development * test caching * fix types
…31835) * internal: (cy.prompt) handle errors better in the command definition * internal: (cy.prompt) add timeout and handle loading errors more cleanly * add process environment variable * clean up test * update JSDoc
* chore: handle errors * Fix ts, add test * Fix error title * Fix ts * Fix ts
* share error utils with cloud * additional rework * Fix command, add isOpenMode * Add / fix test * fix ts --------- Co-authored-by: Ryan Manuel <[email protected]>
…31904) * chore: (cy.prompt) add infrastructure to support a Get Code modal * fix tests * fix code paths * Update eject button styles * handle errors * update types * Update packages/server/lib/socket-base.ts * Fix cy test * update readme --------- Co-authored-by: estrada9166 <[email protected]>
* chore: (cy.prompt) refactor getTestsState to take a runnable id * fix tests * minor tweak
…31922) * chore: (cy.prompt) add manifest for all of the cloud delivered files * fix tests and remove environment variables * update strategy * fix build * rework * require manifest * clean up * refactor * refactor * Update packages/server/lib/cloud/cy-prompt/CyPromptLifecycleManager.ts Co-authored-by: Matt Schile <[email protected]> * fix test --------- Co-authored-by: Matt Schile <[email protected]>
* feat: add cy prompt more info needed modal * Reset promptStore * additional things exposed for more info * rework * fix tests * fix build * fix types * fix types * Update packages/app/src/runner/event-manager.ts Co-authored-by: Copilot <[email protected]> * reefactor * chore: (cy.prompt) rework the file save lifecycle * rework types * add unit tests --------- Co-authored-by: estrada9166 <[email protected]> Co-authored-by: Copilot <[email protected]>
…root in the cy.prompt modals (#32011) * fix: (studio) ensure that we do not attach a vue ref to the react root in the studio panel * fix test
Co-authored-by: Ryan Manuel <[email protected]>
ryanthemanuel
requested review from
brian-mann and
jennifer-shehane
as code owners
ryanthemanuel
changed the title
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
ryanthemanuel
commented
Oct 4, 2025
jennifer-shehane
approved these changes
Oct 6, 2025
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
jennifer-shehane
requested changes
Oct 6, 2025
ryanthemanuel
requested review from
jennifer-shehane,
tgriesser and
estrada9166
jennifer-shehane
approved these changes
Oct 6, 2025
|
Overriding to merge here as the failing test is unrelated and will be fixed separately. |
|
Released in This comment thread has been locked. If you are still experiencing this issue after upgrading to |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Additional details
This PR renames
excludeFromAItoplaceholdersas the option tocy.promptthat provides key/value pairs that will not be sent to AI and will allow caching to work properly by not including the value in the cached text.Steps to test
How has the user experience changed?
PR Tasks
cypress-documentation?type definitions?Note
Rename
PromptOptions.excludeFromAItoplaceholders, bump cy-prompt session mount version to 2 and drop bundle mount-version header, and update CircleCI branch filters.Cypress.PromptOptionsfield fromexcludeFromAItoplaceholdersincli/types/cypress.d.ts.cyPromptMountVersionfrom1to2inpost_cy_prompt_sessionand tests.x-cypress-cy-prompt-mount-versionheader from bundle fetch inget_cy_prompt_bundleand tests.feat/cy-prompttoryanm/fix/rename-exclude-from-aiin.circleci/src/pipeline/@pipeline.ymland.circleci/src/pipeline/workflows/@main.yml.Written by Cursor Bugbot for commit 9e3ede9. This will update automatically on new commits. Configure here.