Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(deps): update @octokit/core to 6.1.4 #1361

Merged
merged 3 commits into from
Feb 18, 2025

Conversation

MikeMcC399
Copy link
Collaborator

Situation

Dependabot reports:

Assessment

These are the current dependency hierarchies:

$ npm ls @octokit/request-error
@cypress/[email protected]
└─┬ @octokit/[email protected]
  ├── @octokit/[email protected]
  └─┬ @octokit/[email protected]
    └── @octokit/[email protected] deduped

$ npm ls @octokit/request
@cypress/[email protected]
└─┬ @octokit/[email protected]
  ├─┬ @octokit/[email protected]
  │ └── @octokit/[email protected] deduped
  └── @octokit/[email protected]

As potential mitigation paths:

@octokit/[email protected] uses vulnerable "@octokit/request-error": "^3.0.0"
@octokit/[email protected] uses vulnerable "@octokit/request": "^8.3.1"

leaving only:

@octokit/[email protected] that resolves the vulnerabilities and that is the lowest possible version

Other compatibility considerations:

@octokit/[email protected] migrated to be an ESM package

Loading ECMAScript modules using require() was added into Node.js v20.17.0

GitHub Actions node20 uses NODE20_VERSION="20.18.2" (see https://github.com/actions/runner/blob/main/src/Misc/externals.sh) and so supports require(ESM).

Change

@octokit/core is updated from @octokit/[email protected] to @octokit/[email protected]

This resolves the vulnerabilities reported by Dependabot.

@MikeMcC399 MikeMcC399 added bug Something isn't working type: dependencies labels Feb 15, 2025
@MikeMcC399 MikeMcC399 self-assigned this Feb 15, 2025
@cypress-app-bot
Copy link

@MikeMcC399 MikeMcC399 marked this pull request as ready for review February 15, 2025 09:43
@jennifer-shehane jennifer-shehane merged commit 18a6541 into cypress-io:master Feb 18, 2025
74 checks passed
Copy link

🎉 This PR is included in version 6.7.12 🎉

The release is available on:

Your semantic-release bot 📦🚀

@MikeMcC399 MikeMcC399 deleted the update/octokit-core branch February 18, 2025 17:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants