Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

search_query: fix filtering unindexed messages in squat backend #4698

Merged
merged 1 commit into from
Oct 25, 2023

Conversation

rsto
Copy link
Member

@rsto rsto commented Oct 24, 2023

The squat backend returns false positives for unindexed messages, but filtering these messages has been broken.

This patch fixes that based on a contribution of @gbulfon. Thanks!

Fixes #4692

Copy link
Contributor

@elliefm elliefm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Couple of nits/suggestions, but it doesn't need re-review as long as CI passes.

cassandane/Cassandane/Cyrus/SearchSquat.pm Outdated Show resolved Hide resolved
imap/search_query.c Outdated Show resolved Hide resolved
@elliefm elliefm added backport-to-3.6 for PRs that are to be backported to 3.6 backport-to-3.4 for PRs that are to be backported to 3.4 backport-to-3.2 for PRs that are to be backported to 3.2 backport-to-3.8 for PRs that are to be backported to 3.8 labels Oct 24, 2023
The squat backend returns false positives for unindexed messages,
but filtering these messages has been broken.

This patch fixes that based on a contribution of @gbulfon. Thanks!

Fixes #4692
@rsto rsto force-pushed the squat_fix_unindexed branch from 4ef2657 to 59d41a0 Compare October 25, 2023 09:10
@rsto rsto merged commit 6be590f into master Oct 25, 2023
2 checks passed
@rsto rsto deleted the squat_fix_unindexed branch October 25, 2023 10:56
@elliefm elliefm removed backport-to-3.8 for PRs that are to be backported to 3.8 backport-to-3.6 for PRs that are to be backported to 3.6 labels Jan 15, 2024
@elliefm elliefm removed backport-to-3.4 for PRs that are to be backported to 3.4 backport-to-3.2 for PRs that are to be backported to 3.2 labels Mar 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Not yet squattered emails are always returned on any search (3.4 and later)
2 participants