cassandane: infer needs from wants/magic #5037
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This should let us reduce a lot of test setup clutter!
one problem is that the missing features test happens very early! if we get wants from :want_foo then those have already been processed but if we get wants from ordinary magic (e.g. :Replication), that magic doesn't get invoked until _create_instances() is run, and at that point it's too late to start adding stuff to the needs hash, the skip_missing_features filter has already run! can we _run_magic() earlier, perhaps? the alternative is needing to add a bunch of :want_replica and such to tests that previously implicitly got that by having "replication" in their name or ":Replication" in their attributes.
this allows the want->needs mappings to work, but all the "magic attribute sets config..." logging now happens at cassandane startup instead of when the test actually runs, which is pretty annoying XXX for some reason this makes a lot of tests fail with "mailbox already exists" when setting up the cassandane user. have no idea why!
elliefm
force-pushed
the
v311/cass-map-wants-needs
branch
from
044590f
to
69a02a1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.