Replace Travis with GitHub Actions and fix test failures #855
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
path sometimes gets overwritten with something that shouldn't be freed, while the registry value always needs to be freed. The easiest way to do this is to separate them. Signed-off-by: Paul Arthur <[email protected]>
Signed-off-by: Paul Arthur <[email protected]>
SASL_PATH has no effect since 79827fb Signed-off-by: Paul Arthur <[email protected]>
This doesn't feel quite right, but it does work. Signed-off-by: Paul Arthur <[email protected]>
Signed-off-by: Paul Arthur <[email protected]>
Signed-off-by: Paul Arthur <[email protected]>
mistotebe
requested changes
Jan 9, 2025
There was a problem hiding this comment.
Hi @flowerysong thanks for the work, would you be able to move the channel binding commit and the SASLDB_FREEPATH commit into their own PRs? The rest look good to go in together.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Runs the automated test suite using GHA. You can see it in action at https://github.com/flowerysong/cyrus-sasl/actions
Related: #852, #853, #854 (macOS uses NDBM for the PLAIN tests)
Closes #822.
Closes #747.