Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: apply bugbears linting checks #388

Draft
wants to merge 1 commit into
base: ci/update-ruff-to-0.3.4
Choose a base branch
from

Conversation

kenibrewer
Copy link
Member

@kenibrewer kenibrewer commented Mar 30, 2024

Description

Should be merged after #386

This applies the bugbear set of linting checks and makes appropriate fixes. The most commonly addressed linting failure that was fixed in this PR is B006. In cases where the mutable default was a list, it was replaces with an immutable tuple instead. For mutable dictionaries, the fix instead involved setting the default to None and initializing the default within the function.

What is the nature of your change?

  • Bug fix (fixes an issue).
  • Enhancement (adds functionality).
  • Breaking change (fix or feature that would cause existing functionality to not work as expected).
  • This change requires a documentation update.

Checklist

Please ensure that all boxes are checked before indicating that a pull request is ready for review.

  • I have read the CONTRIBUTING.md guidelines.
  • My code follows the style guidelines of this project.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • New and existing unit tests pass locally with my changes.
  • I have added tests that prove my fix is effective or that my feature works.
  • I have deleted all non-relevant text in this pull request template.

@kenibrewer kenibrewer changed the base branch from main to ci/update-ruff-to-0.3.4 March 30, 2024 19:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant