Add dark mode style color for contrast in docs #429
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR addresses #428 by allowing the documentation to use distinct colors for styling in light and dark modes. While I made these changes I also slightly reorganized the comments and code nearby for the Sphinx theme configuration.
Additionally, I noticed Read the Docs builds were failing, seemingly due to the environment not installing properly from Poetry. I added a small fix to
.readthedocs.yml
to try and re-enable builds which seems to have worked.I manually tested the web accessibility of the color contrast using Lighthouse through the developer console in Chrome. Let me know if you think we should update the color to a different one based on the contrast or how it aligns with other styling.
Closes #428
What is the nature of your change?
Checklist
Please ensure that all boxes are checked before indicating that a pull request is ready for review.
📚 Documentation preview 📚: https://pycytominer--429.org.readthedocs.build/en/429/