Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(python): bump minimum Python version to 3.9 #464

Merged
merged 3 commits into from
Oct 30, 2024

Conversation

d33bs
Copy link
Member

@d33bs d33bs commented Oct 29, 2024

Description

This PR bumps the minimum Python version required by Pycytominer to 3.9 (3.8 will no longer be compatible). Python 3.8 is end-of-life as of this month and there are related dependency issues which could possibly be resolved by removing Python 3.8 as a minimum version.

Thanks for any feedback!

Closes #433

What is the nature of your change?

  • Bug fix (fixes an issue).
  • Enhancement (adds functionality).
  • Breaking change (fix or feature that would cause existing functionality to not work as expected).
  • This change requires a documentation update.

Checklist

Please ensure that all boxes are checked before indicating that a pull request is ready for review.

  • I have read the CONTRIBUTING.md guidelines.
  • My code follows the style guidelines of this project.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • New and existing unit tests pass locally with my changes.
  • I have added tests that prove my fix is effective or that my feature works.
  • I have deleted all non-relevant text in this pull request template.

@codecov-commenter
Copy link

codecov-commenter commented Oct 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.73%. Comparing base (e8880bc) to head (09b9cef).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #464      +/-   ##
==========================================
- Coverage   94.74%   94.73%   -0.01%     
==========================================
  Files          57       57              
  Lines        3156     3155       -1     
==========================================
- Hits         2990     2989       -1     
  Misses        166      166              
Flag Coverage Δ
unittests 94.73% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@d33bs d33bs marked this pull request as ready for review October 29, 2024 16:17
Copy link
Member

@kenibrewer kenibrewer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@d33bs Can you update this line
to py39 and rerun ruff for the new changes?

Copy link
Member

@gwaybio gwaybio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great to see! Let's also see if @kenibrewer has any comments.

@d33bs - is it worth also addressing #435 here (or soon)?

@d33bs
Copy link
Member Author

d33bs commented Oct 29, 2024

Can you update this line
to py39 and rerun ruff for the new changes?

Thanks @kenibrewer ! I've just added changes which bump the ruff target version and make related typing changes.

@d33bs - is it worth also addressing #435 here (or soon)?

Thanks @gwaybio ! My feeling is that Python 3.12 could possibly have surprises for us that lead to more complex changes or decision-making (I don't know of anything off-hand, but I expect something could pop up). This might be over-doing it, but as a result, I think it might be good to keep those changes in an adjacent PR.

@d33bs d33bs requested a review from kenibrewer October 29, 2024 19:50
@kenibrewer kenibrewer merged commit 63f728a into cytomining:main Oct 30, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Deprecate Python 3.8 usage within project
4 participants