-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build(python): bump minimum Python version to 3.9 #464
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #464 +/- ##
==========================================
- Coverage 94.74% 94.73% -0.01%
==========================================
Files 57 57
Lines 3156 3155 -1
==========================================
- Hits 2990 2989 -1
Misses 166 166
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
great to see! Let's also see if @kenibrewer has any comments.
Co-Authored-By: Ken Brewer <[email protected]>
Thanks @kenibrewer ! I've just added changes which bump the Thanks @gwaybio ! My feeling is that Python 3.12 could possibly have surprises for us that lead to more complex changes or decision-making (I don't know of anything off-hand, but I expect something could pop up). This might be over-doing it, but as a result, I think it might be good to keep those changes in an adjacent PR. |
Description
This PR bumps the minimum Python version required by Pycytominer to 3.9 (3.8 will no longer be compatible). Python 3.8 is end-of-life as of this month and there are related dependency issues which could possibly be resolved by removing Python 3.8 as a minimum version.
Thanks for any feedback!
Closes #433
What is the nature of your change?
Checklist
Please ensure that all boxes are checked before indicating that a pull request is ready for review.