Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix breadthfirst layout to stay inside viewport on fit: false and no boundingBox #3294

Merged
merged 2 commits into from
Nov 11, 2024

Conversation

soetji
Copy link
Contributor

@soetji soetji commented Nov 8, 2024

Associated issues:

**Notes

  • This PR fixes the issue above, from:
Screen.Recording.2024-11-08.at.1.09.35.PM.mov
  • This PR fixes the issue above, to:
Screen.Recording.2024-11-08.at.2.46.12.PM.mov

Checklist

Author:

  • The proper base branch has been selected. New features go on unstable. Bug-fix patches can go on either unstable or master.
  • Automated tests have been included in this pull request, if possible, for the new feature(s) or bug fix. Check this box if tests are not pragmatically possible (e.g. rendering features could include screenshots or videos instead of automated tests).
  • The associated GitHub issues are included (above).
  • Notes have been included (above).

Reviewers:

  • All automated checks are passing (green check next to latest commit).
  • At least one reviewer has signed off on the pull request.
  • For bug fixes: Just after this pull request is merged, it should be applied to both the master branch and the unstable branch. Normally, this just requires cherry-picking the corresponding merge commit from master to unstable -- or vice versa.

@soetji soetji changed the title Fix breadthfirst layout to stay inside viewport on fit: false Fix breadthfirst layout to stay inside viewport on fit: false and no boundingBox Nov 8, 2024
@mikekucera mikekucera merged commit dd0e9f8 into cytoscape:unstable Nov 11, 2024
1 check passed
@mikekucera
Copy link
Contributor

Thanks!

@soetji
Copy link
Contributor Author

soetji commented Nov 12, 2024

@mikekucera What is cytoscape's schedule for new releases?

@mikekucera
Copy link
Contributor

Not sure exactly. We'll probably do a feature release within the next few weeks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants