Support falcon datasets with latest micromanager #237
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ziw-liu
reviewed
Aug 10, 2024
|
|
||
| except Exception: | ||
| labels = [pos.get("Label") for pos in self.stage_positions] | ||
| raise ValueError( |
There was a problem hiding this comment.
I feel that we have made this pile of error catching too big over time. At this point a regex match at the top and throwing early is probably a better solution.
There was a problem hiding this comment.
And by 'too big' I mean a 20-character indentation 😅
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for
Tested on:
Input:
/hpc/instruments/cm.falcon/zebrafish/20240808_coro1a_mpeg_1dpf_10x/fish_with_coro1a_1/Output:
/hpc/projects/balla_group/imaging/zebrafish_infection/falcon/2024_08_08_coro1a_mpeg_1dpf_10x/0-zarr/timelapse1.zarr@ieivanov the new Tile Creator prefix format might affect OPS in this future, so I'm requesting your review.
@dsundarraman heads up that we need to convert with this branch going forward.