Skip to content

Commit

Permalink
fix(build): Add remote function benchmark under benchmark flags
Browse files Browse the repository at this point in the history
The remote function benchmarks are built without checking if the benchmark
utilities are being built. These are only built if certain flags are set.

This causes upstream issues in Prestissimo because there remote functions
are being built but the benchmarks are not.

PR introducing the breaking change:
facebookincubator#11539
  • Loading branch information
czentgr committed Dec 18, 2024
1 parent 01e755c commit 2cd7668
Showing 1 changed file with 2 additions and 0 deletions.
2 changes: 2 additions & 0 deletions velox/functions/remote/CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -16,4 +16,6 @@ add_subdirectory(if)
add_subdirectory(client)
add_subdirectory(server)
add_subdirectory(utils)
if(${VELOX_ENABLE_BENCHMARKS})
add_subdirectory(benchmarks)
endif()

0 comments on commit 2cd7668

Please sign in to comment.