-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ability to persist CT indexes and resume from the saved index file #49
Open
messede-degod
wants to merge
5
commits into
d-Rickyy-b:master
Choose a base branch
from
messede-degod:feat/ct-index-save-restore
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Ability to persist CT indexes and resume from the saved index file #49
messede-degod
wants to merge
5
commits into
d-Rickyy-b:master
from
messede-degod:feat/ct-index-save-restore
+140
−9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
messede-degod
commented
Jan 14, 2025
- Allows CT index to persisted.
- CT indexes are dumped to disk every 30 seconds
- Future sessions resume from last saved CT index.
d-Rickyy-b
reviewed
Jan 15, 2025
d-Rickyy-b
reviewed
Jan 15, 2025
d-Rickyy-b
reviewed
Jan 15, 2025
d-Rickyy-b
reviewed
Jan 15, 2025
d-Rickyy-b
reviewed
Jan 15, 2025
d-Rickyy-b
reviewed
Jan 15, 2025
d-Rickyy-b
reviewed
Jan 15, 2025
Thank you for your contribution :) I appreciate it a lot. I left some comments on the code. Feel free to reply and/or fix. |
I've addressed all your comments, please do take a look and let me know what you think. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.