Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat: Added favicons #162

Merged
merged 1 commit into from
Sep 30, 2024
Merged

Feat: Added favicons #162

merged 1 commit into from
Sep 30, 2024

Conversation

Kingcedru
Copy link
Contributor

@Kingcedru Kingcedru commented Sep 27, 2024 •
edited
Loading

Description:

  • Added favicons in the index.html file.

Acceptance Criteria:

  • The page shows fav icons
  • The types of favicons are available in the webpage
  • The project is running without any issues.

@Kingcedru Kingcedru linked an issue Sep 27, 2024 that may be closed by this pull request
Favicons are missing in the frontend #151
Closed
divinecharlotte
divinecharlotte approved these changes Sep 30, 2024
View reviewed changes
Copy link
Contributor

@divinecharlotte divinecharlotte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good now 👍

@musayann musayann merged commit 3dc4bf5 into develop Sep 30, 2024
6 checks passed
@musayann musayann deleted the ft/add-favicons branch September 30, 2024 14:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@musayann musayann musayann approved these changes

@divinecharlotte divinecharlotte divinecharlotte approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Favicons are missing in the frontend
3 participants
@Kingcedru @musayann @divinecharlotte