Feat: Added a default time frame #176
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
divinecharlotte
previously approved these changes
Oct 8, 2024
musayann
requested changes
Oct 8, 2024
| @@ -31,6 +31,7 @@ export class AllMetereadsComponent implements OnInit { | |||
| dataSource: MatTableDataSource<any>; | |||
| readdata: any; | |||
|
|
|||
| startDate: Date = new Date(new Date().setMonth(new Date().getMonth() - 1)); | |||
There was a problem hiding this comment.
let's not add a new class property for this. We only need this value when initializing
| @@ -284,7 +285,7 @@ export class AllMetereadsComponent implements OnInit { | |||
| this.externalId = result.externalId; | |||
| } | |||
|
|
|||
| this.FilterForm.controls['start'].setValue(result.commissioningDate); | |||
| this.FilterForm.controls['start'].setValue(this.startDate); | |||
There was a problem hiding this comment.
I would suggest instead to set it to
this.FilterForm.controls['start'].setValue(result.commissioningDate || startDate);There was a problem hiding this comment.
We should set this date to the startDate that you have calculated as a fallback. The default behavior should be to use the commissioningDate
musayann
approved these changes
Oct 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective:
Description:
Acceptance Criteria: