Automate translation files #880
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Better than being a magic number somewhere in the code, source code gets it from source.json
Wolfvak
approved these changes
Nov 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In response to a conversation with @ihaveamac on Discord, this makes the
language.inlfile be automatically generated fromsource.jsonon runningmake. It will be automatically regenerated if, and only if,source.jsonchanges on non-clean builds.Edit: I noticed the Spanish TRF was outdated which made me realize there's no particular reason I can think of not to automate those too so I added that in f48f0d5.
I also moved the translation version number to the JSON instead of being a magic number hidden away elsewhere in the code. This does not need to be manually bumped for translations, Crowdin will handle it automatically. It just needs to be bumped any time the order of
source.jsonchanges, insource.jsonitself.