feat: move volume property from bottle to wine entry #124
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Aside from giving a way to reflect the mere fact that some wines come in very specific bottle sizes (think of Radikon, Marsala, etc.), it also allows to distinguish wines of different size: price and rating-wise. And indeed, magnum bottles are often quite different - not only they do have their own evolution compared to normal bottles, sometimes they are even crafted differently (a common thing within Champagne). So practically, thus also means that one should create separate wine entries for different volumes. P.S. If you have troubles migrating, simply run the following SQL: ALTER TABLE bottle DROP COLUMN volume; There is no migration routine as I haven't seen users of vino-inv yet.
|
I will address the failing tests shortly™. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Aside from giving a way to reflect the mere fact that some wines come in very specific bottle sizes (think of Radikon, Marsala, etc.), it also allows to distinguish wines of different size: price and rating-wise. And indeed, magnum bottles are often quite different - not only they do have their own evolution compared to normal bottles, sometimes they are even crafted differently (a common thing within Champagne).
So practically, thus also means that one should create separate wine entries for different volumes.
P.S. If you have troubles migrating, simply run the following SQL:
There is no migration routine as I haven't seen users of
vino-invyet.