fix: move all default DamageModifierResponse values to use Default::default instead #107
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…efault instead This is in preparation for Melee damage handling
BarmonHammer
approved these changes
Apr 22, 2024
…ded in the near future This should be removed once we expect no more fields to be added to the struct. https://doc.rust-lang.org/reference/attributes/type_system.html#the-non_exhaustive-attribute This prevents clippy from flagging the use of default on fully-specified struct values.
BarmonHammer
approved these changes
Apr 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is in preparation for Melee damage handling from #105.
Any scalar here that previously used a value of '1.0' has been removed (to pick up defaults), and all DamageModifierResponses now specify
..Default::default()so that any updates to the DamageModifierResponse struct will not require updating every single perk.Add non_exhausive to DamageModifierResponse as it will have fields added in the near future
This should be removed once we expect no more fields to be added to the struct.
https://doc.rust-lang.org/reference/attributes/type_system.html#the-non_exhaustive-attribute
This prevents clippy from flagging the use of default on fully-specified struct values.