Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/dewrangle volume hash #3

Merged
merged 12 commits into from
Mar 18, 2024
Merged

Conversation

sickler-alex
Copy link
Contributor

Pull Request Name

[Description here]

This PR removes the dewrangle command and adds a volume command and hash subcommand. The hash command is largely a copy from https://github.com/d3b-center/dewrangle-python. I'm going to reorganize and document it in a later PR, but this serves as an initial copy.

@sickler-alex sickler-alex force-pushed the feature/dewrangle_volume_hash branch from 8171760 to fb8400e Compare March 14, 2024 15:25
@HuangXiaoyan0106
Copy link
Contributor

@sickler-alex Is there any reason, why we don't use d3b dewrangle as the main command? I'm thinking there will be several sub-commands like hash volume, list volume...

I think the main commands should be structured around the key categories.

d3b validation
d3b dewrangle
d3b registration
...

@sickler-alex
Copy link
Contributor Author

That's a good question and I don't really have a good reason. I renamed it Dewrangle in #4.

@HuangXiaoyan0106
Copy link
Contributor

That's a good question and I don't really have a good reason. I renamed it Dewrangle in #4.

yeah, have approved 4 and this one.

🚚 use token option when creating client
@sickler-alex sickler-alex merged commit 442f74a into master Mar 18, 2024
@sickler-alex sickler-alex deleted the feature/dewrangle_volume_hash branch March 18, 2024 14:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants