-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CLI Refactor #224
Merged
Merged
CLI Refactor #224
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NicEastvillage
added
the
refactoring
Rewriting or restructuring of existing features
label
Sep 14, 2023
falkecarlsen
requested changes
Sep 14, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, some comments om SEMVER and args
Co-authored-by: Falke Carlsen <[email protected]>
falkecarlsen
approved these changes
Sep 15, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR refactors our CLI
Notable changes for usage:
cgaal solver
andcgaal global
has been merged tocgaal check
--global
will make cgaal use the global algorithm (and conflicts with--search-strategy=
)cgaal check mymodel.lcgs myquery.atl
instead ofcgaal solver -m mymodel.lcgs -f myformula.atl
Notable internal changes:
args.rs
load.rs
CliOptions
structstd::exit
, using Results insteadMore refactoring is possible. E.g. update clap and use the new derive pattern (essentially the cli is generated from a struct like
CliOptions
), search strategy dispatching still cause a lot of duplicate code, but I will stop here before the PR gets too big.