Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SPSH-1733: use separate store for filtered schulen #424

Merged
merged 20 commits into from
Feb 12, 2025
Merged

SPSH-1733: use separate store for filtered schulen #424

merged 20 commits into from
Feb 12, 2025

Conversation

clauyan
Copy link
Contributor

@clauyan clauyan commented Jan 31, 2025

Description

  • refactor KlasseCreation to use a separate store for filtered schulen to avoid stale data in store

Links to Tickets or other PRs

Notes

Approval for review

  • All points were discussed with the ticket creator, support-team or product owner. The code upholds all quality guidelines from the PR-template.

Notice: Please remove the WIP label if the PR is ready to review, otherwise nobody will review it.

@clauyan clauyan marked this pull request as ready for review February 3, 2025 14:00
jaggarnaut
jaggarnaut requested changes Feb 4, 2025
View reviewed changes
src/components/form/KlasseForm.spec.ts Outdated Show resolved Hide resolved
src/stores/OrganisationStore.spec.ts Outdated Show resolved Hide resolved
src/views/admin/KlasseCreationView.spec.ts Outdated Show resolved Hide resolved
YoussefBouch
YoussefBouch requested changes Feb 5, 2025
View reviewed changes
src/stores/OrganisationStore.ts Outdated Show resolved Hide resolved
src/stores/OrganisationStore.ts Outdated Show resolved Hide resolved
src/stores/OrganisationStore.ts Outdated Show resolved Hide resolved
@clauyan clauyan requested a review from YoussefBouch February 10, 2025 12:14
YoussefBouch
YoussefBouch reviewed Feb 10, 2025
View reviewed changes
src/views/admin/KlasseCreationView.vue Outdated Show resolved Hide resolved
src/views/admin/KlasseCreationView.vue Outdated Show resolved Hide resolved
YoussefBouch
YoussefBouch approved these changes Feb 10, 2025
View reviewed changes
Copy link
Contributor

@YoussefBouch YoussefBouch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved ist es aber trotzdem :) Bitte vor dem mergen noch fail_on_vulnerabilites: false auf true setzen.

@clauyan clauyan merged commit 2712912 into main Feb 12, 2025
30 checks passed
@clauyan clauyan deleted the SPSH-1733 branch February 12, 2025 11:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@YoussefBouch YoussefBouch YoussefBouch approved these changes

@jaggarnaut jaggarnaut jaggarnaut approved these changes

Assignees

@clauyan clauyan

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@clauyan @YoussefBouch @jaggarnaut @tikle-cap