[WIP] Replace No Web3 Dialog with Web3Connect #245
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Agreed @nickplace, the reason we chose to do this was because we wanted the whole application to be usable without a metamask popup. Then when you click "Deploy", you're asked to provide a wallet. I think we can continue to do this while not polluting the migration component :P |
|
Should this issue be included in the new project board or tagged as a |
|
@orishim included in the new project board. I think we'll also want to add this to the existing tool (V1), and I plan to review and finish implementing this PR very shortly. |
dOrgJelli
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the future, we should take all of the network / wallet logic out of the Migration component. References issue #223