[WIP] Cotary Create: Adding basic support for the Ethereum Name Service #355 #357
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Flash-Git this has no code changes, so it doesn't look like it's actually ENS support. Going to close for now. |
|
I was asked to open pull requests on active issues because it's a lot easier to share and visualise progress this way than it is when looking at individual branches. |
|
Oh whoops my bad, didn't know :P |
dOrgJelli
changed the title
|
No problem! The web3 version had to be updated before work can begin because of the recent migration. |
|
On further examination this cannot be done from the UI and will require a lib change because of how we validate fields. Going to follow your lead and close this for now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#355