Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

homebase-dao-deployer: Optimize by Refactoring Duplicated Code #741

Closed
benefacto opened this issue Dec 29, 2023 · 4 comments
Closed

homebase-dao-deployer: Optimize by Refactoring Duplicated Code #741

benefacto opened this issue Dec 29, 2023 · 4 comments
Assignees

Comments

@benefacto
Copy link
Member

benefacto commented Dec 29, 2023

Description:
The off-chain DAO deployer, the homebase-dao-deployer project, currently contains a significant amount of duplicated code. This duplication seems to have originated from adapting the existing homebase-app to create an Express server-based solution for deploying DAOs. This issue aims to track the effort to refactor and optimize the codebase, removing unnecessary duplication and improving overall efficiency.

Background:
The original DAO contracts were too large for direct deployment through the Tezos wallet. As a workaround, an Express API server was developed to handle DAO deployments via JSON requests. During this process, code from homebase-app was largely repurposed, leading to redundancy in the codebase.

Tasks:

  1. Identify Redundant Code: Review the current codebase to pinpoint exact areas of duplication. This may require a comparison with the original homebase-app code.

  2. Plan for Refactoring: Develop a clear refactoring strategy that outlines which parts of the code are to be modified, consolidated, or removed.

  3. Implement Code Refactoring: Carry out the planned refactoring, ensuring that no essential functionality is lost or negatively impacted.

  4. Documentation Update: Update any related documentation to reflect changes made during the refactoring process.

Expected Outcome:
The refactored off-chain DAO deployer should be more efficient, with reduced code redundancy, while maintaining all existing functionalities. This should simplify future maintenance and potentially improve deployment performance.

Additional Notes:

  • Collaboration with developers familiar with the original homebase-app and the current deployer is advised for better understanding and efficient refactoring.
@benefacto benefacto self-assigned this Dec 29, 2023
@benefacto benefacto changed the title Optimize Off-chain DAO Deployer by Refactoring Duplicated Code homebase-dao-deployer: Optimize by Refactoring Duplicated Code Dec 29, 2023
@benefacto
Copy link
Member Author

benefacto commented Dec 29, 2023

@Man-Jain I understand that the homebase-dao-deployer is hosted on AWS. Is it possible for me to be granted access to it?

@benefacto
Copy link
Member Author

WIP pull request: dOrgTech/homebase-dao-deployer#1

@benefacto
Copy link
Member Author

Reconsider, maybe hombase should be moved to Next.js, maybe follow up with Manak

@benefacto
Copy link
Member Author

This entire repository should be deprecated by #507 so no need for a refactor

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant