-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Resolving Endpoint Regression and Codebase Refinement #21
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benefacto
changed the title
Regression in Homebase Lite Backend Causing Incorrect Endpoint Response
Resolving Endpoint Regression and Codebase Refinement
Jan 16, 2024
benefacto
requested review from
Man-Jain,
EightRice,
fabiolalombardim and
thenerdcat
January 16, 2024 01:23
Man-Jain
approved these changes
Jan 25, 2024
EightRice
approved these changes
Jan 29, 2024
logic for xtz weighted polls
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This pull request delivers crucial fixes and improvements to the Homebase Lite Backend, primarily focusing on rectifying a regression issue that affected endpoint responses. Additionally, it includes enhancements to our testing framework and repository management. These changes are in response to the regression problem outlined in ZenHub Issue #756, aiming to bolster the reliability and maintainability of the project.
Key Changes
node_modules
from the source, aligning with best practices and simplifying future code reviews. The folder was already listed in.gitignore
and its removal eliminates unnecessary bulk from the repository.node_modules
directory significantly reduces the diff size, aiding in the review process. Reviewers can collapse this folder in the diff view for easier navigation. Theyarn.lock
file is retained to ensure build reproducibility.Linked Issue
This pull request addresses the concerns and objectives laid out in the ZenHub issue: Homebase Lite Backend: Regression in Homebase Lite Backend Causing Incorrect Endpoint Response #756. The issue highlighted critical disruptions in API functionality due to incorrect endpoint responses, which this pull request aims to comprehensively resolve.
This format maintains the structure and style of your previous pull requests, ensuring consistency in your project documentation and communication.